settings: add jinja2 support (bug 1873071) #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zzzeid
commented
Jan 4, 2024
zzzeid
commented
- add jinja2 to requirements
- update settings to pick up jinja2 templates
- add basic jinja2 environment to lando
cgsheeh
requested changes
Jan 8, 2024
| @@ -0,0 +1,15 @@ | |||
| from django.templatetags.static import static | |||
There was a problem hiding this comment.
What else is going to go in this module? Could we just put this in settings.py?
There was a problem hiding this comment.
What else is going to go in this module? Could we just put this in
settings.py?
This is the typical way of adding a Jinja environment. Basically all the filters and custom functionality we added (e.g., template_helpers) in the legacy repo will eventually go in here. This doesn't belong in the settings module.
Templates are already in the base branch, and are moved in PR #21, and will be properly ported in a different PR, since they all depend on various functionality that is not available at this time. |
cgsheeh
approved these changes
Jan 8, 2024
zzzeid
force-pushed
the
zeid/bug-1870697-clean-up-ui-files
branch
from
0da890f to
6b8aa78
Compare
- add jinja2 to requirements - update settings to pick up jinja2 templates - add basic jinja2 environment to lando
zzzeid
force-pushed
the
zeid/bug-1873071-jinja2
branch
from
548a015 to
5e2a6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.